Press n or j to go to the next uncovered block, b, p or k for the previous block.
| 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 | import { useState, useEffect, useRef, type JSX } from "react"; import type { ToastVariant } from "../../context/ToastContext.js"; import type { TaskData, Workspace, PersonaData } from "../../hooks/types.js"; import { taskUrl, workspaceUrl, useAppNavigate } from "../../utils/navigation.js"; import styles from "./TaskEditPanel.module.scss"; /** Props for the TaskEditPanel component. */ interface Props { mode: "new" | "edit"; /** Task ID — required in edit mode. */ taskId?: string; /** Workspace ID — required in new mode. */ workspaceId?: string; /** Parent task ID — optional in new mode. */ parentTaskId?: string; /** Environment ID — used for scoped navigation. */ environmentId?: string; /** All tasks (used for lookups and sibling dependency list). */ tasks: TaskData[]; /** All workspaces (used for workspace selector and environment resolution). */ workspaces: Workspace[]; /** All personas (used for persona dropdown). */ personas: PersonaData[]; /** Callback to create a new task. */ onCreateTask: ( workspaceId: string, title: string, description?: string, dependsOn?: string[], parentTaskId?: string, defaultPersonaId?: string, canDecompose?: boolean, injectKnowledge?: boolean, onSuccess?: () => void, onError?: (message: string) => void, ) => void; /** Callback to update an existing task. */ onUpdateTask: ( taskId: string, title: string, description: string, dependsOn: string[], defaultPersonaId?: string, ) => void; /** Optional callback invoked when inline edit completes (save or cancel). When provided, navigation is skipped. */ onEditDone?: () => void; /** Display a toast notification. */ onShowToast?: (message: string, variant?: ToastVariant) => void; } /** * Full-panel create/edit form for tasks. * * - new: blank form; calls createTask on save, then navigates back to * the workspace view. * - edit: pre-populated form; calls updateTask on save, then navigates * back to the task overview. */ export function TaskEditPanel({ mode, taskId, workspaceId: workspaceIdProp, parentTaskId: parentTaskIdProp, environmentId: environmentIdProp, tasks, workspaces, personas, onCreateTask, onUpdateTask, onEditDone, onShowToast, }: Props): JSX.Element { const navigate = useAppNavigate(); const isEdit = mode === "edit"; const existingTask = isEdit && taskId ? tasks.find((t) => t.id === taskId) : undefined; const initialWorkspaceId = isEdit ? (existingTask?.workspaceId ?? "") : (workspaceIdProp ?? ""); const [selectedWorkspaceId, setSelectedWorkspaceId] = useState(initialWorkspaceId); const workspaceId = initialWorkspaceId || selectedWorkspaceId; /** Resolve environmentId from prop, or from the workspace's first linked environment. */ const resolvedWorkspace = workspaces.find((w) => w.id === workspaceId); const environmentId = environmentIdProp ?? resolvedWorkspace?.linkedEnvironmentIds[0]; /** Whether the workspace dropdown should be shown (new mode without pre-set workspace). */ const showWorkspaceSelector = !isEdit && !workspaceIdProp; const parentTaskId = isEdit ? (existingTask?.parentTaskId ?? "") : (parentTaskIdProp ?? ""); const parentTask = parentTaskId ? tasks.find((t) => t.id === parentTaskId) : undefined; const [title, setTitle] = useState(existingTask?.title ?? ""); const [description, setDescription] = useState(existingTask?.description ?? ""); const [selectedDeps, setSelectedDeps] = useState<string[]>(existingTask?.dependsOn ?? []); const [defaultPersonaId, setDefaultPersonaId] = useState(existingTask?.defaultPersonaId ?? ""); const [canDecompose, setCanDecompose] = useState(existingTask?.canDecompose ?? false); const [injectKnowledge, setInjectKnowledge] = useState(existingTask?.injectKnowledge ?? true); const [creating, setCreating] = useState(false); // In edit mode, tasks may not have loaded yet at mount time. Sync form state // the first time existingTask becomes available so the form is pre-populated, // but do not re-apply on subsequent refreshes — that would discard in-progress // user edits whenever a background update replaces the task object. const hasHydratedRef = useRef(false); useEffect(() => { if (isEdit && existingTask && !hasHydratedRef.current) { hasHydratedRef.current = true; setTitle(existingTask.title); setDescription(existingTask.description); setSelectedDeps(existingTask.dependsOn); setDefaultPersonaId(existingTask.defaultPersonaId); setCanDecompose(existingTask.canDecompose); setInjectKnowledge(existingTask.injectKnowledge); } }, [isEdit, existingTask]); // All tasks in the same workspace, excluding the task being edited (self) const siblingTasks = tasks.filter( (t) => t.workspaceId === workspaceId && (!isEdit || t.id !== taskId) && t.id !== parentTaskId, ); // In edit mode, also require that task data has loaded before allowing save // to prevent overwriting server data with blank form values. // Workspace is required: the user must pick one from the dropdown. const canSave = title.trim().length > 0 && (!isEdit || existingTask !== undefined) && workspaceId.length > 0; const toggleDep = (depId: string): void => { setSelectedDeps((prev) => prev.includes(depId) ? prev.filter((d) => d !== depId) : [...prev, depId], ); }; const handleSave = (): void => { if (!canSave || creating) { return; } if (isEdit && existingTask === undefined) { // Guard: task data not yet loaded — do not overwrite with blank values. return; } if (isEdit && taskId) { onUpdateTask(taskId, title.trim(), description, selectedDeps, defaultPersonaId); onShowToast?.("Task updated", "success"); if (onEditDone) { onEditDone(); } else { navigate(taskUrl(taskId, undefined, workspaceId, environmentId), { replace: true }); } } else { setCreating(true); onCreateTask( workspaceId, title.trim(), description, selectedDeps.length > 0 ? selectedDeps : undefined, parentTaskId || undefined, defaultPersonaId, canDecompose, injectKnowledge, () => { onShowToast?.("Task created", "success"); navigate(workspaceIdProp ? workspaceUrl(workspaceIdProp, environmentId) : "/tasks", { replace: true, }); }, (message: string) => { onShowToast?.(message, "error"); setCreating(false); }, ); } }; const handleCancel = (): void => { if (onEditDone) { onEditDone(); return; } if (isEdit && taskId) { navigate(taskUrl(taskId, undefined, workspaceId, environmentId)); } else { navigate(workspaceIdProp ? workspaceUrl(workspaceIdProp, environmentId) : "/tasks"); } }; const modeLabel = isEdit ? "edit task" : parentTaskId ? "child task" : "new task"; return ( <div className={styles.container}> {/* Header */} <div className={styles.header}> <div className={styles.headerTitle}> <span className={styles.badge}>{modeLabel}</span> {parentTask && ( <span className={styles.parentContext}> <span className={styles.parentLabel}>Child of</span> <span className={styles.parentName}>{parentTask.title}</span> </span> )} </div> <div className={styles.headerActions}> <button onClick={handleSave} disabled={!canSave || creating} className={styles.btnPrimary} data-testid="task-edit-save" > {creating ? "Creating\u2026" : isEdit ? "Save Changes" : "Create"} </button> <button onClick={handleCancel} className={styles.btnGhost}> Cancel </button> </div> </div> {/* Form body */} <div className={styles.body}> <div className={styles.formContent}> {/* Workspace selector (shown when creating from global Tasks view) */} {showWorkspaceSelector && ( <div className={styles.section}> <label className={styles.label} htmlFor="task-edit-workspace"> Workspace </label> <select id="task-edit-workspace" value={selectedWorkspaceId} onChange={(e) => setSelectedWorkspaceId(e.target.value)} className={styles.personaSelect} data-testid="task-edit-workspace" > <option value="">Select a workspace...</option> {workspaces.map((w) => ( <option key={w.id} value={w.id}> {w.name} </option> ))} </select> </div> )} {/* Title */} <div className={styles.section}> <label className={styles.label} htmlFor="task-edit-title"> Title </label> <input id="task-edit-title" type="text" value={title} onChange={(e) => setTitle(e.target.value)} placeholder="Task title..." autoFocus className={styles.titleInput} data-testid="task-edit-title" onKeyDown={(e) => { if (e.key === "Enter" && canSave) { handleSave(); } }} /> </div> {/* Description */} <div className={styles.section}> <label className={styles.label} htmlFor="task-edit-description"> Description </label> <textarea id="task-edit-description" value={description} onChange={(e) => setDescription(e.target.value)} placeholder="Describe the task... (markdown supported)" className={styles.descriptionTextarea} data-testid="task-edit-description" rows={8} /> </div> {/* Default Persona */} <div className={styles.section}> <label className={styles.label} htmlFor="task-edit-persona"> Default Persona </label> <select id="task-edit-persona" value={defaultPersonaId} onChange={(e) => setDefaultPersonaId(e.target.value)} className={styles.personaSelect} data-testid="task-edit-persona" > <option value="">(Inherit)</option> {personas.map((p) => ( <option key={p.id} value={p.id}> {p.name} </option> ))} </select> </div> {/* Can Decompose */} {!isEdit && ( <div className={styles.section}> <label className={styles.depItem} data-testid="task-edit-can-decompose"> <input type="checkbox" checked={canDecompose} onChange={(e) => setCanDecompose(e.target.checked)} /> Can spawn subtasks </label> </div> )} {/* Inject Knowledge (#1259) */} {!isEdit && ( <div className={styles.section}> <label className={styles.depItem} data-testid="task-edit-inject-knowledge"> <input type="checkbox" checked={injectKnowledge} onChange={(e) => setInjectKnowledge(e.target.checked)} /> Inject related prior work from the knowledge graph </label> </div> )} {/* Dependencies */} <div className={styles.section}> <div className={styles.label}>Dependencies</div> {siblingTasks.length === 0 ? ( <div className={styles.noDeps}>No other tasks in this workspace</div> ) : ( <div className={styles.depList}> {siblingTasks.map((t) => { const isChecked = selectedDeps.includes(t.id); return ( <label key={t.id} className={`${styles.depItem} ${isChecked ? styles.depItemSelected : ""}`} data-testid={`dep-option-${t.id}`} > <input type="checkbox" checked={isChecked} onChange={() => toggleDep(t.id)} /> {t.title} <span style={{ opacity: 0.5, fontSize: "11px", marginLeft: "4px" }}> ({t.status}) </span> </label> ); })} </div> )} </div> </div> </div> </div> ); } |