Press n or j to go to the next uncovered block, b, p or k for the previous block.
| 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 | 1x 15x 15x 15x 15x 15x 15x 15x 15x 1x 26x 26x 26x 26x 26x 15x 15x 15x 1x 1x 1x 1x 14x 14x 26x 26x 26x 26x 26x 26x 26x 26x 26x 26x 11x 15x 26x 15x 11x 26x 11x 11x 11x 11x 11x 11x 11x 14x 14x 14x 14x 14x 14x 14x 14x 14x 3x 14x 11x 11x 1x 11x 11x 11x 11x 11x 25x 25x 25x 25x 25x 11x 11x 25x 25x 25x 25x 25x 25x 21x 21x 21x 21x 25x 25x 25x 2x 25x 21x 21x 21x 59x 4x 4x 4x 59x 21x 21x 21x 14x 14x 14x 14x 14x 14x 14x 14x 2x 2x 8x 8x 14x 14x 2x 2x 12x 12x 14x 14x 14x 2x 2x 2x 2x 2x 2x 2x 1x 1x 1x 1x 2x 2x 8x 8x 8x 8x 8x 8x 1x 1x 1x 1x 1x 7x 8x 2x 8x 2x 8x 8x 26x 26x 26x 26x 26x 67x 67x 29x 67x 29x 67x 26x 26x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 14x 2x 2x 12x 14x 2x 2x 14x 8x 8x 2x 2x 14x 14x 9x 9x 9x 14x 3x 3x 3x 2x 2x 2x 4x 4x 4x 1x 1x 1x 1x 1x 1x 1x 14x 14x 14x 15x 1x 1x 1x 14x 14x | /**
* Java resolveCallSites — name-based catalog lookup.
*
* Tree-sitter has no symbol table, so we resolve by simple name. For
* each call site:
*
* 1. Decode the called expression. Three node kinds surface as calls:
* - `method_invocation` — name from the `name` field.
* Covers `foo(...)`, `obj.foo(...)`, `Class.foo(...)`,
* `this.foo(...)`, `super.foo(...)` — all have the same shape.
* - `object_creation_expression` — `new Foo(...)`. The target
* is the type name (`Foo`), which matches the constructor's
* `simpleName` since constructors carry their class name.
* - `explicit_constructor_invocation` — `super(...)` or
* `this(...)` inside a constructor body. We map `super` →
* unresolved (parent type unknown without full lookup) and
* `this` → unresolved (we can't tell which sibling ctor without
* argument-arity matching, which is out of scope).
*
* 2. Look up matching catalog entries by simple name. Confidence
* ladder mirrors graph-python/graph-go:
* - 0 matches → `to: []`, resolution `'unknown'`, confidence `'low'`
* - 1 match → `to: [hash]`, resolution `'static'`, confidence `'medium'`
* - N matches → `to: [allHashes]`, resolution `'method-dispatch'`,
* confidence `'low'`
*
* Per I-4: this function does NOT mutate the input catalog.
*/
import { logger } from '@opensip-tools/core';
import {
appendEdge,
createMutableStats,
pushCreationEdge,
truncateForCallEdge,
} from '@opensip-tools/graph';
import type { JavaParsedFile, JavaParsedProject } from './parse.js';
import type {
Catalog,
CallEdge,
DependencyEdge,
DependencySiteRecord,
FunctionOccurrence,
MutableStats,
ResolutionStats,
ResolveInput,
ResolveOutput,
} from '@opensip-tools/graph';
import type Parser from 'tree-sitter';
function javaPosition(node: Parser.SyntaxNode, file: JavaParsedFile): {
readonly line: number;
readonly column: number;
readonly text: string;
} {
return {
line: node.startPosition.row + 1,
column: node.startPosition.column,
text: file.source.slice(node.startIndex, node.endIndex),
};
}
export function resolveCallSites(input: ResolveInput<JavaParsedProject>): ResolveOutput {
logger.info({ evt: 'graph.edges.start', module: 'graph:edges:java' });
const byName = buildNameIndex(input.catalog.functions);
const edgesByOwner = new Map<string, CallEdge[]>();
const stats = createMutableStats();
for (const r of input.callSites) {
const node = r.nodeRef as Parser.SyntaxNode;
const file = r.sourceFileRef as JavaParsedFile;
if (r.kind === 'creation') {
if (r.childHash === undefined) continue;
pushCreationEdge(node, file, r.ownerHash, r.childHash, edgesByOwner, stats, javaPosition);
continue;
}
pushCallEdge(node, file, r.ownerHash, byName, edgesByOwner, stats);
}
const finalStats: ResolutionStats = {
totalCallSites: stats.totalCallSites,
resolvedHigh: stats.resolvedHigh,
resolvedMedium: stats.resolvedMedium,
resolvedLow: stats.resolvedLow,
unresolved: stats.unresolved,
};
logger.info({ evt: 'graph.edges.complete', module: 'graph:edges:java', ...finalStats });
// Phase 4 (DEC-498): resolve dependency sites if any. Mirrors the
// other tree-sitter adapters' resolveDependencies pattern, adapted to
// Java's package = directory-mirror convention.
const dependenciesByOwner =
input.dependencySites && input.dependencySites.length > 0
? resolveDependencies(input.dependencySites, input.catalog)
: undefined;
return dependenciesByOwner === undefined
? { edgesByOwner, stats: finalStats }
: { edgesByOwner, dependenciesByOwner, stats: finalStats };
}
/**
* Resolve Java `import` sites to target module-init bodyHashes.
*
* Java has a strict directory-mirrors-package convention: the package
* `com.example.foo` lives at directory `com/example/foo/`. A type `Bar`
* in that package lives in `com/example/foo/Bar.java`. We build two
* lookup tables off this convention:
*
* 1. **By type FQN** — `com.example.foo.Bar` → bodyHash of the
* `Bar.java` module-init. Used for plain type imports.
* 2. **By package FQN** — `com.example.foo` → bodyHash[] (one per
* `*.java` file in that package). Used for wildcard imports
* (`import com.example.foo.*;`).
*
* Source-root inference: source roots vary by build system. We check
* the canonical Maven/Gradle layouts (`src/main/java/`, `src/test/java/`),
* the plain `src/` layout, and the project-root layout (`''`) in that
* order, using the first prefix that strictly contains the file path.
* Non-default Gradle `sourceSets`, multi-module Maven layouts, and
* generated-source dirs (`target/generated-sources/...`) are NOT handled
* — files outside the four canonical roots fall back to project-root
* and may produce inflated FQNs that miss the lookup (those imports
* surface as `to: []`, which is the correct unresolved behavior).
*
* Stdlib classes (`java.*`, `javax.*`, `jakarta.*`) are treated as
* external — they're never in the project catalog so we short-circuit
* to `to: []` without attempting lookup.
*
* Phase 4 of opensip's substrate consolidation (DEC-498).
*/
function resolveDependencies(
sites: readonly DependencySiteRecord[],
catalog: Catalog,
): ReadonlyMap<string, readonly DependencyEdge[]> {
const { typeFQN, packageFQN } = buildJavaFQNIndex(catalog);
const out = new Map<string, DependencyEdge[]>();
for (const site of sites) {
const to = resolveJavaImportSpecifier(site.specifier, typeFQN, packageFQN);
const edge: DependencyEdge = {
to,
line: site.line,
column: site.column,
specifier: site.specifier,
};
const existing = out.get(site.ownerHash);
if (existing === undefined) {out.set(site.ownerHash, [edge]);}
else {existing.push(edge);}
}
return out;
}
/** The canonical source-root prefixes we recognize, in priority order.
* First strict-prefix match on a catalog file's filePath wins. */
const JAVA_SOURCE_ROOT_PREFIXES = ['src/main/java/', 'src/test/java/', 'src/'] as const;
/**
* Build both FQN lookup maps from the catalog's module-init occurrences.
*
* For each module-init occurrence:
* 1. Strip a recognized source-root prefix (or `''` for project-root).
* 2. Strip the `.java` extension.
* 3. Slash-to-dot → that's the type FQN. The package is everything
* before the last dot.
*/
function buildJavaFQNIndex(catalog: Catalog): {
readonly typeFQN: ReadonlyMap<string, string>;
readonly packageFQN: ReadonlyMap<string, readonly string[]>;
} {
const typeFQN = new Map<string, string>();
const packageFQN = new Map<string, string[]>();
for (const occs of Object.values(catalog.functions)) {
if (!occs) continue;
for (const o of occs) {
indexModuleInitOccurrence(o, typeFQN, packageFQN);
}
}
return { typeFQN, packageFQN };
}
/**
* Index a single catalog occurrence into the FQN maps. No-op for any
* occurrence that isn't a `module-init` or whose filePath doesn't
* resolve to a Java type FQN.
*/
function indexModuleInitOccurrence(
o: FunctionOccurrence,
typeFQN: Map<string, string>,
packageFQN: Map<string, string[]>,
): void {
if (o.kind !== 'module-init') return;
const fqn = filePathToJavaTypeFQN(o.filePath);
if (fqn === null) return;
typeFQN.set(fqn, o.bodyHash);
const lastDot = fqn.lastIndexOf('.');
const pkg = lastDot === -1 ? '' : fqn.slice(0, lastDot);
const bucket = packageFQN.get(pkg);
if (bucket === undefined) packageFQN.set(pkg, [o.bodyHash]);
else bucket.push(o.bodyHash);
}
/**
* Map a project-relative POSIX filePath to its Java type FQN. Returns
* `null` when the file doesn't end in `.java` (defensive — the discover
* pass should already filter by extension, but module-init occurrences
* could in principle carry any path).
*
* Examples:
* - `src/main/java/com/example/foo/Bar.java` → `com.example.foo.Bar`
* - `src/test/java/com/example/FooTest.java` → `com.example.FooTest`
* - `src/com/example/foo/Bar.java` → `com.example.foo.Bar`
* - `com/example/foo/Bar.java` → `com.example.foo.Bar`
* - `Bar.java` → `Bar` (default package)
*/
function filePathToJavaTypeFQN(filePath: string): string | null {
if (!filePath.endsWith('.java')) /* v8 ignore next */ return null;
let stripped = filePath;
for (const prefix of JAVA_SOURCE_ROOT_PREFIXES) {
if (filePath.startsWith(prefix)) {
stripped = filePath.slice(prefix.length);
break;
}
}
const noExt = stripped.slice(0, -'.java'.length);
return noExt.replaceAll('/', '.');
}
/**
* Resolve one Java import-specifier string to its target module-init
* bodyHash(es).
*
* Stdlib short-circuit: `java.*`, `javax.*`, `jakarta.*` are never in
* the catalog. The `kotlin.*` and `scala.*` runtimes are similarly
* external for Java projects, but we don't special-case them — they
* fall through to the type-FQN lookup and miss naturally.
*
* Static imports always target a static MEMBER (method or field) of
* a class. The class's module-init occurrence is the dependency target,
* so we strip the trailing identifier before lookup. Static wildcards
* (`static com.foo.Bar.*`) target all static members of one class — same
* type lookup as plain static imports.
*/
function resolveJavaImportSpecifier(
specifier: string,
typeFQN: ReadonlyMap<string, string>,
packageFQN: ReadonlyMap<string, readonly string[]>,
): readonly string[] {
const { raw, isStatic } = parseStaticPrefix(specifier);
// Stdlib short-circuit. These never reside in a project catalog.
if (isJavaStdlibSpecifier(raw)) return [];
if (raw.endsWith('.*')) {
return resolveWildcardImport(raw.slice(0, -'.*'.length), isStatic, typeFQN, packageFQN);
}
return resolveSingleTargetImport(raw, isStatic, typeFQN);
}
/** Strip a leading `static ` keyword, returning the remainder and the flag. */
function parseStaticPrefix(specifier: string): { readonly raw: string; readonly isStatic: boolean } {
if (specifier.startsWith('static ')) {
return { raw: specifier.slice('static '.length), isStatic: true };
}
return { raw: specifier, isStatic: false };
}
function isJavaStdlibSpecifier(raw: string): boolean {
return raw.startsWith('java.') || raw.startsWith('javax.') || raw.startsWith('jakarta.');
}
/**
* Wildcard imports come in two flavors:
* - `<pkg>.*` (non-static) → all types in the package.
* - `<type>.*` (static) → all static members of the type, which
* resolves to that type's module-init.
*/
function resolveWildcardImport(
head: string,
isStatic: boolean,
typeFQN: ReadonlyMap<string, string>,
packageFQN: ReadonlyMap<string, readonly string[]>,
): readonly string[] {
if (isStatic) {
const hash = typeFQN.get(head);
return hash === undefined ? [] : [hash];
}
const bucket = packageFQN.get(head);
return bucket === undefined ? [] : [...bucket];
}
/**
* Non-wildcard imports target exactly one type's module-init.
*
* - Static (`static com.foo.Bar.method`) — strip the trailing member
* identifier; the remainder is the owning type's FQN.
* - Plain (`com.foo.Bar`) — direct FQN lookup, with a one-level
* inner-class fallback for `Outer.Inner`-shaped imports (a
* heuristic, since `Outer.Inner` and `package.Type` are
* structurally indistinguishable without declaring-file resolution).
*/
function resolveSingleTargetImport(
raw: string,
isStatic: boolean,
typeFQN: ReadonlyMap<string, string>,
): readonly string[] {
if (isStatic) {
const lastDot = raw.lastIndexOf('.');
if (lastDot === -1) return [];
const hash = typeFQN.get(raw.slice(0, lastDot));
return hash === undefined ? [] : [hash];
}
const direct = typeFQN.get(raw);
if (direct !== undefined) return [direct];
const lastDot = raw.lastIndexOf('.');
if (lastDot === -1) return [];
const outer = typeFQN.get(raw.slice(0, lastDot));
return outer === undefined ? [] : [outer];
}
function buildNameIndex(
functions: Readonly<Record<string, readonly FunctionOccurrence[]>>,
): ReadonlyMap<string, readonly string[]> {
const out = new Map<string, string[]>();
for (const [name, occs] of Object.entries(functions)) {
if (!occs) continue;
if (name.startsWith('<')) continue;
const list: string[] = out.get(name) ?? [];
for (const o of occs) list.push(o.bodyHash);
if (list.length > 0) out.set(name, list);
}
return out;
}
function pushCallEdge(
node: Parser.SyntaxNode,
file: JavaParsedFile,
ownerHash: string,
byName: ReadonlyMap<string, readonly string[]>,
edgesByOwner: Map<string, CallEdge[]>,
stats: MutableStats,
): void {
stats.totalCallSites++;
const target = extractCallTargetName(node);
const pos = javaPosition(node, file);
const truncated = truncateForCallEdge(pos.text);
const discarded = isReturnValueDiscarded(node);
const edge = buildJavaCallEdge(target, byName, {
line: pos.line,
column: pos.column,
text: truncated,
discarded,
});
appendEdge(edgesByOwner, ownerHash, edge);
stats.apply(edge);
}
interface CallEdgeLoc {
readonly line: number;
readonly column: number;
readonly text: string;
readonly discarded: boolean;
}
function buildJavaCallEdge(
target: string | null,
byName: ReadonlyMap<string, readonly string[]>,
loc: CallEdgeLoc,
): CallEdge {
if (target === null) {
return { to: [], ...loc, resolution: 'unknown', confidence: 'low' };
}
const matches = byName.get(target);
if (!matches || matches.length === 0) {
return { to: [], ...loc, resolution: 'unknown', confidence: 'low' };
}
if (matches.length === 1) {
return { to: [...matches], ...loc, resolution: 'static', confidence: 'medium' };
}
return { to: [...matches], ...loc, resolution: 'method-dispatch', confidence: 'low' };
}
/**
* Decode a Java call-site node's target into a simple name. Returns
* null when the shape isn't one we recognize.
*/
function extractCallTargetName(node: Parser.SyntaxNode): string | null {
if (node.type === 'method_invocation') {
const name = node.childForFieldName('name');
return name ? name.text : null;
}
if (node.type === 'object_creation_expression') {
// `new Foo(...)` — target is the type name. The `type` field holds
// a type_identifier (`Foo`), generic_type (`Foo<T>`), or
// scoped_type_identifier (`pkg.Foo`).
const ty = node.childForFieldName('type');
return ty ? decodeTypeName(ty) : null;
}
if (node.type === 'explicit_constructor_invocation') {
// `super(...)` or `this(...)`. We can't disambiguate constructor
// overloads without argument-arity matching against the catalog,
// and `super` targets a parent class we may not have. Leave
// unresolved (callers will see the edge with text but to=[]).
return null;
}
/* v8 ignore next */
return null;
}
function decodeTypeName(node: Parser.SyntaxNode): string | null {
if (node.type === 'type_identifier') return node.text;
if (node.type === 'generic_type') {
const inner = node.childForFieldName('type') ?? node.namedChild(0);
return inner ? decodeTypeName(inner) : null;
}
if (node.type === 'scoped_type_identifier') {
// `pkg.Foo` — trailing identifier is the type.
const last = node.namedChild(node.namedChildCount - 1);
return last ? last.text : null;
}
/* v8 ignore next */
return null;
}
/**
* The call's return value is discarded when its parent is an
* expression_statement.
*/
function isReturnValueDiscarded(node: Parser.SyntaxNode): boolean {
let parent: Parser.SyntaxNode | null = node.parent;
while (parent) {
if (parent.type === 'parenthesized_expression') {
parent = parent.parent;
continue;
}
return parent.type === 'expression_statement';
}
/* v8 ignore next */
return false;
}
|