# UpdateGoodsIssue

## Permission Scope

inventoryOperation

## Overview

updateGoodsIssue updates a DRAFT goods issue InventoryExecution via `headerPatch` and revises its outbound InventoryExecutionLine set via `addLines`, `updateLines`, and `removeLineIds`.

## Business Rules

- The target InventoryExecution must exist, have `executionType=GOODS_ISSUE`, and be in DRAFT status
- Posted goods issues cannot be updated
- effectiveDate can be updated independently
- sourceDocumentType and sourceDocumentId are immutable after creation
- `updateLines` and `removeLineIds` must target a line that exists on the execution
- `updateLines` patches the existing line in place, so its id and createdAt are preserved
- At least one line must remain after the changes
- Added and updated lines follow the same validation rules as createGoodsIssue
- Added and updated lines must provide both source-unit quantity/unitId and converted primaryQuantity/unitConversionRate snapshots
- Added and updated line primaryUnitId must equal Item.unitId
- Goods issue valuation derives cost from the active valuation policy during posting; unit cost is not accepted as command input
- No stock or ledger changes occur during update

## Process Flow

```mermaid
flowchart TD
    A[Update goods issue request] --> B[Lock InventoryExecution]
    B --> C{GOODS_ISSUE and DRAFT?}
    C -->|No| D[Return error: INVALID_STATUS]
    C -->|Yes| E{Target lines exist?}
    E -->|No| F[Return error: ISSUE_LINE_NOT_FOUND]
    E -->|Yes| H{At least one line remains?}
    H -->|No| I[Return error: EMPTY_ISSUE_LINES]
    H -->|Yes| J[Validate added and updated lines]
    J --> K[Apply header updates and line changes]
    K --> M[Return execution and lines]
```

## External Dependencies

- [item-management::Item](../../../item-management/docs/model/Item.md) - Validates referenced items
- [inventory::InventoryExecution](../model/InventoryExecution.md) - Updates the goods issue execution header and revises outbound execution lines

## Error Scenarios

- **INVALID_STATUS**: Target entity is not in a valid status for this operation
- **ISSUE_LINE_NOT_FOUND**: Referenced goods issue line does not exist on the target execution
- **EMPTY_ISSUE_LINES**: No goods issue lines were provided
- **INVALID_QUANTITY**: Quantity is zero or negative
- **PRIMARY_UNIT_MISMATCH**: primaryUnitId differs from Item.unitId
- **INVALID_UNIT_CONVERSION_RATE**: Unit conversion rate is zero or negative
- **ITEM_NOT_FOUND**: Referenced item does not exist
- **STORAGE_LOCATION_NOT_FOUND**: Referenced storage location does not exist
- **LOT_NOT_FOUND**: Referenced lot does not exist
- **SERIAL_NOT_FOUND**: Referenced serial number does not exist

## Test Cases

- updates header metadata on a draft goods issue
- updates a line in place so its id and createdAt survive the edit
- adds a goods issue line via addLines
- removes a goods issue line via removeLineIds
- returns error when an update targets a missing line
- returns error when a removal would leave the goods issue without lines
- returns error when an added line primary quantity is zero or negative
- returns error when an added line unit conversion rate is zero or negative
- returns error when an added line primary unit differs from item primary unit
