myles.borins
19:18
please lmk if there is a better place to put this information
6.2.146
[1] and fixed in V8 6.3.166
[2].6.3.292
in the master, and V8 6.1.something
for 2.0.x
releases, so we should be safe at least for now.$ git branch -r --contains 596d55a | head branch-heads/6.3 branch-heads/6.4 branch-heads/6.5 branch-heads/6.6 origin/6.3-lkgr origin/6.3.166(edited)
Traceback (most recent call last): File "/Users/codebytere/Developer/libchromiumcontent/script/apply-patches", line 8, in <module> from lib.patches import PatchesConfig File "/Users/codebytere/Developer/libchromiumcontent/script/lib/patches.py", line 6, in <module> import yaml ImportError: No module named yamlwhen i run script/update…any ideas? (edited)
chromium-upgrade/66
, https://github.com/electron/libchromiumcontent/commits/chromium-upgrade/66Error: 11 patch(es) failed: patches/common/chromium/web_contents.patch patches/common/chromium/webgl_context_attributes.patch patches/common/chromium/worker_context_will_destroy.patch patches/common/chromium/webui_in_subframes.patch patches/common/chromium/export_blink_webdisplayitemlist.patch patches/common/chromium/restore_adding_custom_cors_enabled_schemes.patch patches/common/chromium/latency_histogram_macros.patch patches/common/chromium/gin_enable_disable_v8_platform.patch patches/common/chromium/disable-recursive-surface-sync.patch patches/common/chromium/can_disable_desktop_capture_throttling.patch patches/common/chromium/patch_catalog_vuln.patch
upgrade-to-chromium-66
branch to electron/electron
so folks can play with stuff. Won't make a PR yet. Also pushed up a tmp-66
branch to electron/node
which upgrades node to the branch in targos's PR linked above.
resource_request_details.patch
the corresponding electron api for which it is used, will be gone because of https://bugs.chromium.org/p/chromium/issues/detail?id=783981. I have already removed the event as a part of plznavigate https://github.com/electron/electron/commit/686c3d49690c7737c896ea552f9bc0ee5eebd544 because with browser side navigation every request has a corresponding blob request (this will improve with chromium 67 where mojo data pipes are used) and this event is just triggered twice as much with no usefulness for end users. Also when this event was created there wasn't any alternative, but later webRequest api was added which provides utilities to observe the same. So i am removing this event in favor of fixing all these problems.
BrowserThread::FILE
has been removed in https://chromium-review.googlesource.com/890263.../../atom/browser/api/frame_subscriber.h:10:10: fatal error: 'content/browser/renderer_host/render_widget_host_view_frame_subscriber.h' file not found It has been removed in https://crrev.com/c/896588
create_window
fixup!
commits.native-mate
submodule and probably some others.
undefined symbol: viz:::FrameSinkVideoConsumer*
errors.atom:::FrameSubscriber
. Any ideas how they can be fixed?//services/viz
as a dep in our build.gn
, AFAICS it's not being built currently
//services/viz
added to deps and then built Electron. Got the same linking errors.
//services/viz
pull everything starting with //services/viz
? the implementation I used as a base has //services/viz/privileged/interfaces/compositing
as a dep
services/viz/privileged/interfaces/compositing
was built
create-dist
script is not copying the built lib files, but this is a bit beyond my skills
source_set
by //services/viz:lib
, we should create a library target depending on it in the component_build
. The more we use mojo, we will be facing with this issue. Another reason why electron has to be built as a part of libcc.
(edited)
source_set
s at all. Maybe we can build them all as static libraries?
source_set
allows us to workaround the current issue by linking them into our custom library target and exporting it.